Ticket #186 (new enhancement)

Opened 9 years ago

SVD can possibly be improved?

Reported by: emmenlau Owned by: emmenlau
Priority: minor Milestone: XuvTools-1.8.1-final
Component: xuvtools Version: 1.8.0-beta3
Keywords: SVD, singular, value, decomposition, eigen, gsl Cc: developers@…

Description

The SVD in the two files:

xuvtools/src/xuvstitch/libCrossCorrelation.cc
xuvtools/test/singular_value_decomposition/singular_value_decomposition.cc

can possibly be improved. The current implementation builds the matrix with the stack number as column. This is likely not ideal, because the stack numbers don't always start at zero (and are consegutively numbered). I.e. when SVD'ing only a subset of the stacks, this claim is not true. Also, providing a wrong number of images breaks the function, but the parameter is not useful?

Even better, the interface should not ask for stack numbers. The returned image positions should simply correspond to the given displacements, the stack number and number of images is implicit?

Note: See TracTickets for help on using tickets.