Ticket #48 (accepted defect)

Opened 11 years ago

Last modified 10 years ago

xuvtools: bleaching correction crashes when starting preview

Reported by: emmenlau Owned by: emmenlau
Priority: unimportant Milestone:
Component: xuvtools Version:
Keywords: bleaching correction, xuvtools, crash Cc: developers@…

Description

As soon as preview is clicked, the bleaching correction preview crashes.

Change History

Changed 11 years ago by ummenhof

  • owner changed from emmenlau to ummenhof
  • status changed from new to assigned

Changed 11 years ago by emmenlau

In xuvBleachCorrect.cc the Array type is requested from GenFile?, which for some reason seems not to work. A workaround / improvement is to take the Array type that is available in the config map. Change:

float getOverexposedValue(Bleachcorrect::Stack& stack)
{
  int type = 0;
  try {
    type = GenFile::getArraytype( stack.filename, stack.stackFileId );
  } catch( GenFileError) {
    // load all as float
    type = GenFile::TYPE_FLOAT;
  }
  [...]

to:

float getOverexposedValue(Bleachcorrect::Stack& stack)
{
  if( stack.datatype == GenFile::NO_TYPE ) {
    // This will actually never happen, because stack.datatype is already known here:
    try {
      stack.datatype = GenFile::getArraytype( stack.filename, stack.stackFileId );
    } catch( GenFileError) {
      // load all as float
      stack.datatype = GenFile::TYPE_FLOAT;
    }
  }
  [...]

Changed 11 years ago by ummenhof

  • cc emmenlau added; ummenhof removed

I changed it but is it really the cause for the crash? I found an uncommitted change (sry!) in my xuvBleachCorrect.cc which is very probably related to this crash. Can you check if it works now?

Changed 11 years ago by emmenlau

Sorry for the late reply, I will try this week!

Changed 11 years ago by emmenlau

  • cc aaron@…, ne704 added
  • status changed from assigned to new

There is another crash that happens for a different reason, but since I currently can not give much details about it, this bug report seems the appropriate place for it.

Reproduce:

  • Open two tiles
  • Run XuvTools?
  • Start Bleaching Correction preview
  • Select "Render Preview" -> Crash.

The backtrace is not helpful:

(gdb) backtrace 
#0  0x00007fff803e1f16 in __kill ()
#1  0x00007fff80452f6d in abort ()
#2  0x00007fff84837085 in __gnu_cxx::__verbose_terminate_handler ()
#3  0x00007fff826b3af3 in _objc_terminate ()
#4  0x00007fff84835425 in __gxx_personality_v0 ()
#5  0x00007fff8483545b in std::terminate ()
#6  0x00007fff8483559d in __cxa_rethrow ()
#7  0x000000010229d383 in QEventLoop::exec ()
#8  0x00000001022a0e55 in QCoreApplication::exec ()
#9  0x0000000100005550 in ?? ()

Changed 10 years ago by emmenlau

  • cc developers@… added; emmenlau, aaron@…, ne704 removed
  • owner changed from ummenhof to emmenlau
  • status changed from new to accepted
  • priority changed from major to unimportant
Note: See TracTickets for help on using tickets.